lkml.org 
[lkml]   [2017]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 1/2] clk: gate: expose clk_gate_ops::is_enabled
Date
Hi Stephen,


On 07/14/2017 08:52 PM, kbuild test robot wrote:
> Hi Gabriel,
>
> [auto build test ERROR on clk/clk-next]
> [also build test ERROR on v4.12 next-20170714]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/gabriel-fernandez-st-com/clk-stm32h7-Add-stm32h743-clock-driver/20170714-170518
> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: arm-lpc32xx_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=arm
>
> All errors (new ones prefixed by >>):
>
>>> drivers/clk/nxp/clk-lpc32xx.c:906:12: error: static declaration of 'clk_gate_is_enabled' follows non-static declaration
> static int clk_gate_is_enabled(struct clk_hw *hw)
> ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/clk/nxp/clk-lpc32xx.c:13:0:
> include/linux/clk-provider.h:346:5: note: previous declaration of 'clk_gate_is_enabled' was here
> int clk_gate_is_enabled(struct clk_hw *hw);
> ^~~~~~~~~~~~~~~~~~~
>
> vim +/clk_gate_is_enabled +906 drivers/clk/nxp/clk-lpc32xx.c
>
> f7c82a60 Vladimir Zapolskiy 2015-12-06 905
> f7c82a60 Vladimir Zapolskiy 2015-12-06 @906 static int clk_gate_is_enabled(struct clk_hw *hw)
> f7c82a60 Vladimir Zapolskiy 2015-12-06 907 {
> f7c82a60 Vladimir Zapolskiy 2015-12-06 908 struct lpc32xx_clk_gate *clk = to_lpc32xx_gate(hw);
> f7c82a60 Vladimir Zapolskiy 2015-12-06 909 u32 val;
> f7c82a60 Vladimir Zapolskiy 2015-12-06 910 bool is_set;
> f7c82a60 Vladimir Zapolskiy 2015-12-06 911
> f7c82a60 Vladimir Zapolskiy 2015-12-06 912 regmap_read(clk_regmap, clk->reg, &val);
> f7c82a60 Vladimir Zapolskiy 2015-12-06 913 is_set = val & BIT(clk->bit_idx);
> f7c82a60 Vladimir Zapolskiy 2015-12-06 914
> f7c82a60 Vladimir Zapolskiy 2015-12-06 915 return (clk->flags & CLK_GATE_SET_TO_DISABLE ? !is_set : is_set);
> f7c82a60 Vladimir Zapolskiy 2015-12-06 916 }
> f7c82a60 Vladimir Zapolskiy 2015-12-06 917 EXPORT_SYMBOL_GPL(__clk_gate_is_enabled);
>
>
> :::::: The code at line 906 was first introduced by commit
> :::::: f7c82a60ba26c2f003662bcb2cff131021c1e828 clk: lpc32xx: add common clock framework driver
>
> :::::: TO: Vladimir Zapolskiy <vz@mleia.com>
> :::::: CC: Michael Turquette <mturquette@baylibre.com>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation

Rename 'clk_gate_is_enabled' into'__clk_gate_is_enabled' from clk-gate.c
file, is it a good solution for you ?

i could add also EXPORT_SYMBOL_GPL(__clk_gate_is_enabled) if you are ok.


Best Regards
Gabriel

\
 
 \ /
  Last update: 2017-07-17 09:31    [W:0.057 / U:2.240 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site