lkml.org 
[lkml]   [2017]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] PCI: dwc: Handle host_init failures
Date
On Monday, July 17, 2017 7:18 AM, Joao Pinto wrote:
>
> Hi Bjorn Andersson,
>
> Às 7:39 AM de 7/16/2017, Bjorn Andersson escreveu:
> > In several dwc based drivers host_init can fail, so make sure to
> > propagate and handle this to avoid continuing operation of a driver or
> > hardware in an invalid state.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > drivers/pci/dwc/pci-dra7xx.c | 4 +++-
> > drivers/pci/dwc/pci-exynos.c | 4 +++-
> > drivers/pci/dwc/pci-imx6.c | 4 +++-
> > drivers/pci/dwc/pci-keystone.c | 4 +++-
> > drivers/pci/dwc/pci-layerscape.c | 14 ++++++++++----
> > drivers/pci/dwc/pcie-armada8k.c | 4 +++-
> > drivers/pci/dwc/pcie-artpec6.c | 4 +++-
> > drivers/pci/dwc/pcie-designware-host.c | 7 +++++--
> > drivers/pci/dwc/pcie-designware-plat.c | 4 +++-
> > drivers/pci/dwc/pcie-designware.h | 2 +-
> > drivers/pci/dwc/pcie-kirin.c | 4 +++-
> > drivers/pci/dwc/pcie-qcom.c | 6 ++++--
> > drivers/pci/dwc/pcie-spear13xx.c | 4 +++-
> > 13 files changed, 47 insertions(+), 18 deletions(-)
> >

[.....]

>
> A step in the right direction :). In the future we should add host init
> validation in the specific SoC drivers, like Layerscape and Qcom have, to
> assure
> that any problem is treated properly in the core driver.

I agree with your opinion.

>
> Acked-by: Joao Pinto <jpinto@synopsys.com>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

\
 
 \ /
  Last update: 2017-07-17 21:28    [W:0.062 / U:0.176 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site