lkml.org 
[lkml]   [2017]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events
On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote:
> Jiri Olsa <jolsa@kernel.org> writes:
> >
> > Setting the reset field to 0 for freq events.
>
> Looks good to me.
>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
>
> BTW I suspect there's a related bug that
>
> perf record -e '{cycles:pp,branches}:S' ..
>
> would enable multi record PEBS, even though it shouldn't because
> we need the PMI to read the other events.

there's PERF_SAMPLE_READ om cycles's sample_type for this example
so it won't pass the x86_pmu::free_running_flags filter

also PERF_SAMPLE_TIME and PERF_SAMPLE_PERIOD will be set
in your example which will prevent that, but those
could be unset via record's '-c xxxx' and '--no-timestamp'

jirka

\
 
 \ /
  Last update: 2017-07-17 13:38    [W:0.046 / U:4.144 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site