Messages in this thread | | | Subject | Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() | From | "Gustavo A. R. Silva" <> | Date | Sun, 16 Jul 2017 23:50:32 -0500 |
| |
On 07/01/2017 02:50 AM, MyungJoo Ham wrote: > On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi, >> >> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >>> Print and propagate the return value of platform_get_irq on failure. >>> >>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >>> --- >>> drivers/devfreq/rk3399_dmc.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>> index 40a2499..1b89ebb 100644 >>> --- a/drivers/devfreq/rk3399_dmc.c >>> +++ b/drivers/devfreq/rk3399_dmc.c >>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >>> >>> irq = platform_get_irq(pdev, 0); >>> if (irq < 0) { >>> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >>> - return -EINVAL; >>> + dev_err(&pdev->dev, >>> + "Cannot get the dmc interrupt resource: %d\n", irq); >>> + return irq; >>> } >>> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >>> if (!data) >>> >> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> >
Thank you, Chanwoo and MyungJoo.
-- Gustavo A. R. Silva
| |