lkml.org 
[lkml]   [2017]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.
From
Date
Sorry for noise. Please ignore this.

~arvind


On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> index 9f5e829..eb88bd9 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> @@ -405,7 +405,7 @@ static int obd_device_list_open(struct inode *inode, struct file *file)
> struct kobject *lustre_kobj;
> EXPORT_SYMBOL_GPL(lustre_kobj);
>
> -static struct attribute_group lustre_attr_group = {
> +static const struct attribute_group lustre_attr_group = {
> .attrs = lustre_attrs,
> };
>

\
 
 \ /
  Last update: 2017-07-17 09:43    [W:0.075 / U:4.276 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site