lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] fat: fix quoted string splits
On Sun, Jul 16, 2017 at 6:06 PM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
>> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@perches.com> wrote:

>> As much as it adds 'error, ' at the beginning of message. I can't
>> consider this a bad idea.
>
> Adding "error" to KERN_ERR output is unnecessary
> and if really desired, should be done by dmesg
> or equivalent.

Shouldn't be fixed in the function itself (__fat_fs_error())?

Anyway, this discussion is obviously for a separate change. The
original patch looks okay.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-07-16 17:31    [W:0.040 / U:5.900 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site