lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 17/95] USB: wusbcore: fix NULL-deref at probe
    3.2.91-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 03ace948a4eb89d1cf51c06afdfc41ebca5fdb27 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer or accessing memory beyond the endpoint array should a
    malicious device lack the expected endpoints.

    This specifically fixes the NULL-pointer dereference when probing HWA HC
    devices.

    Fixes: df3654236e31 ("wusb: add the Wire Adapter (WA) core")
    Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
    Cc: David Vrabel <david.vrabel@csr.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/wusbcore/wa-hc.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/usb/wusbcore/wa-hc.c
    +++ b/drivers/usb/wusbcore/wa-hc.c
    @@ -38,6 +38,9 @@ int wa_create(struct wahc *wa, struct us
    int result;
    struct device *dev = &iface->dev;

    + if (iface->cur_altsetting->desc.bNumEndpoints < 3)
    + return -ENODEV;
    +
    result = wa_rpipes_create(wa);
    if (result < 0)
    goto error_rpipes_create;
    \
     
     \ /
      Last update: 2017-07-16 16:58    [W:4.160 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site