| From | Ben Hutchings <> | Date | Sun, 16 Jul 2017 14:56:38 +0100 | Subject | [PATCH 3.2 30/95] Input: hanwang - validate number of endpoints before using them |
| |
3.2.91-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Johan Hovold <johan@kernel.org>
commit ba340d7b83703768ce566f53f857543359aa1b98 upstream.
Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints.
Fixes: bba5394ad3bd ("Input: add support for Hanwang tablets") Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- drivers/input/tablet/hanwang.c | 3 +++ 1 file changed, 3 insertions(+)
--- a/drivers/input/tablet/hanwang.c +++ b/drivers/input/tablet/hanwang.c @@ -314,6 +314,9 @@ static int hanwang_probe(struct usb_inte int error; int i; + if (intf->cur_altsetting->desc.bNumEndpoints < 1) + return -ENODEV; + hanwang = kzalloc(sizeof(struct hanwang), GFP_KERNEL); input_dev = input_allocate_device(); if (!hanwang || !input_dev) {
|