lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 142/178] l2tp: don't mask errors in pppol2tp_setsockopt()
    3.16.46-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guillaume Nault <g.nault@alphalink.fr>

    commit 364700cf8fd54f54ad08313464105a414e3bccb7 upstream.

    pppol2tp_setsockopt() unconditionally overwrites the error value
    returned by pppol2tp_tunnel_setsockopt() or
    pppol2tp_session_setsockopt(), thus hiding errors from userspace.

    Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
    Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/l2tp/l2tp_ppp.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/net/l2tp/l2tp_ppp.c
    +++ b/net/l2tp/l2tp_ppp.c
    @@ -1402,8 +1402,6 @@ static int pppol2tp_setsockopt(struct so
    } else
    err = pppol2tp_session_setsockopt(sk, session, optname, val);

    - err = 0;
    -
    end_put_sess:
    sock_put(sk);
    end:
    \
     
     \ /
      Last update: 2017-07-16 16:37    [W:4.119 / U:2.856 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site