Messages in this thread | | | Date | Sun, 16 Jul 2017 00:00:31 +0100 (BST) | From | James Simmons <> | Subject | Re: [PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch |
| |
> On Sat, 2017-07-15 at 11:39 -0400, James Simmons wrote: > > Cleanup all braces that was reported by checkpatch. The only > > issue not fixed up is in mdc_lock.c. Removing the braces in > > the case of mdc_lock.c will break the build. > > what checkpatch warning in mdc_locks.c is that? > > $ ./scripts/checkpatch.pl -f --terse --nosummary drivers/staging/lustre/lustre/mdc/mdc_locks.c > drivers/staging/lustre/lustre/mdc/mdc_locks.c:590: WARNING: line over 80 characters > drivers/staging/lustre/lustre/mdc/mdc_locks.c:600: WARNING: line over 80 characters > drivers/staging/lustre/lustre/mdc/mdc_locks.c:637: WARNING: line over 80 characters
For 4.11-xxx kernels I was seeing
WARNING: braces {} are not necessary for any arm of this statement #914: FILE: drivers/staging/lustre/lustre/mdc/mdc_locks.c:914: + if (it->it_op & IT_CREAT) { [...] + } else if (it->it_op == IT_OPEN) { [...] + } else { [...]
Now it doesn't show up.
| |