lkml.org 
[lkml]   [2017]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH for v4.9 LTS 18/87] ASoC: tlv320aic3x: Mark the RESET register as volatile
    Date
    From: Peter Ujfalusi <peter.ujfalusi@ti.com>

    [ Upstream commit 63c3194b82530bd71fd49db84eb7ab656b8d404a ]

    The RESET register only have one self clearing bit and it should not be
    cached. If it is cached, when we sync the registers back to the chip we
    will initiate a software reset as well, which is not desirable.

    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    sound/soc/codecs/tlv320aic3x.c | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
    index 5a8d96ec058c..fe45a16a5142 100644
    --- a/sound/soc/codecs/tlv320aic3x.c
    +++ b/sound/soc/codecs/tlv320aic3x.c
    @@ -126,6 +126,16 @@ static const struct reg_default aic3x_reg[] = {
    { 108, 0x00 }, { 109, 0x00 },
    };

    +static bool aic3x_volatile_reg(struct device *dev, unsigned int reg)
    +{
    + switch (reg) {
    + case AIC3X_RESET:
    + return true;
    + default:
    + return false;
    + }
    +}
    +
    static const struct regmap_config aic3x_regmap = {
    .reg_bits = 8,
    .val_bits = 8,
    @@ -133,6 +143,9 @@ static const struct regmap_config aic3x_regmap = {
    .max_register = DAC_ICC_ADJ,
    .reg_defaults = aic3x_reg,
    .num_reg_defaults = ARRAY_SIZE(aic3x_reg),
    +
    + .volatile_reg = aic3x_volatile_reg,
    +
    .cache_type = REGCACHE_RBTREE,
    };

    --
    2.11.0
    \
     
     \ /
      Last update: 2017-07-15 03:45    [W:4.049 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site