lkml.org 
[lkml]   [2017]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] watchdog: w83627hf: make const array chip_name static
From
Date
On 07/11/2017 08:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate array chip_name on the stack but instead make it static.
> Makes the object code smaller by 40 bytes:
>
> Before:
> text data bss dec hex filename
> 5641 2840 384 8865 22a1 drivers/watchdog/w83627hf_wdt.o
>
> After:
> text data bss dec hex filename
> 5545 2896 384 8825 2279 drivers/watchdog/w83627hf_wdt.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/w83627hf_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/w83627hf_wdt.c b/drivers/watchdog/w83627hf_wdt.c
> index d9ba0496713c..7817836bff55 100644
> --- a/drivers/watchdog/w83627hf_wdt.c
> +++ b/drivers/watchdog/w83627hf_wdt.c
> @@ -429,7 +429,7 @@ static int __init wdt_init(void)
> {
> int ret;
> int chip;
> - const char * const chip_name[] = {
> + static const char * const chip_name[] = {
> "W83627HF",
> "W83627S",
> "W83697HF",
>

\
 
 \ /
  Last update: 2017-07-14 08:40    [W:0.051 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site