lkml.org 
[lkml]   [2017]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots
This patch itself looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

> static struct configfs_attribute *nvmet_subsys_attrs[] = {
> &nvmet_subsys_attr_attr_allow_any_host,
> &nvmet_subsys_attr_version,
> + &nvmet_subsys_attr_attr_serial,

but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up. And we should also add nvmetcli support
for it. Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).

\
 
 \ /
  Last update: 2017-07-14 14:33    [W:0.096 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site