lkml.org 
[lkml]   [2017]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL
    Date
    From: Colin Ian King <colin.king@canonical.com>

    The current check will always be true and will always jump to
    err1, this looks dubious to me. I believe && should be used
    instead of ||.

    Detected by CoverityScan, CID#1450120 ("Logically Dead Code")

    Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    net/sunrpc/xprtrdma/svc_rdma_sendto.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
    index 19fd01e4b690..7c3a211e0e9a 100644
    --- a/net/sunrpc/xprtrdma/svc_rdma_sendto.c
    +++ b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
    @@ -684,7 +684,7 @@ int svc_rdma_sendto(struct svc_rqst *rqstp)
    return 0;

    err2:
    - if (ret != -E2BIG || ret != -EINVAL)
    + if (ret != -E2BIG && ret != -EINVAL)
    goto err1;

    ret = svc_rdma_post_recv(rdma, GFP_KERNEL);
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-07-13 19:52    [W:2.202 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site