Messages in this thread Patch in this message | | | Date | Wed, 12 Jul 2017 22:31:05 +0200 | From | Pavel Machek <> | Subject | omap3isp: is capture mode working? what hardware? was Re: v4l2-fwnode: status, plans for merge, any branch to merge against? |
| |
Hi!
> What I've done is just rebased the ccp2 branch. In other words, the patches > in that branch are no more ready than they were. > > To get these merged we should ideally > > 1) Make sure there will be no regressions,
I grepped dts trees a bit... where is omap3isp currently used? Anything besides N9 and N950?
Does the capture mode currently work for you?
Because as far as I can tell, formatter is disabled, so video is in wrong format for the userspace.
So something like patch below is needed; (of course after adjusting the comment etc.)
Thanks, Pavel
commit eb81524b8b44bbff2518b272cb3de304157bd3ba Author: Pavel <pavel@ucw.cz> Date: Mon Feb 13 21:26:51 2017 +0100
omap3isp: fix VP2SDR bit so capture (not preview) works
This is neccessary for capture (not preview) to work properly on N900. Why is unknown.
diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 7207558..2fb755f 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -1186,7 +1186,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) /* Use the raw, unprocessed data when writing to memory. The H3A and * histogram modules are still fed with lens shading corrected data. */ - syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; +// syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; + syn_mode |= ISPCCDC_SYN_MODE_VP2SDR; if (ccdc->output & CCDC_OUTPUT_MEMORY) syn_mode |= ISPCCDC_SYN_MODE_WEN; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |