Messages in this thread | | | From | Frans Klaver <> | Date | Wed, 12 Jul 2017 10:08:03 +0200 | Subject | Re: [PATCH] staging: ks7010: fix styling WARNINGs |
| |
On Fri, Jun 30, 2017 at 8:39 PM, Mark Rogers <mail@mark-rogers.org> wrote: > Thank you for your feedback. I guess when making this patch I had the > preferred coding style in mind, but didn't ask myself if making the code > conform to it would truly improve readability. > > I agree with all of your comments. Do you think the best course of > action is to create a new patch with this change alone and forget the > rest?
It's up to you. You could send a couple of patches fixing these things, or just do one patch fixing one thing.
> > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); > > Sorry about the newbie questions and bad patch, I will do better with > the next one. Thanks again for your time and feedback, I really > appreciate it.
It's pretty much what staging is for. Don't worry about it.
Frans
| |