Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call | Date | Tue, 11 Jul 2017 20:41:21 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
Currently a sock_release on map->sock will result in a null pointer deference on map when map is null. Instead, the sock_relase sould be on sock and not map->sock.
Detected by CoverityScan, CID#1450169 ("Dereference after null check")
Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/xen/pvcalls-back.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index d6c4c4aecb41..01b690e1e555 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c @@ -424,7 +424,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev, sock); if (!map) { ret = -EFAULT; - sock_release(map->sock); + sock_release(sock); } out: -- 2.11.0
| |