lkml.org 
[lkml]   [2017]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 08/41] usb: dwc3: replace %p with %pK
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felipe Balbi <felipe.balbi@linux.intel.com>

    commit 04fb365c453e14ff9e8a28f1c46050d920a27a4a upstream.

    %p will leak kernel pointers, so let's not expose the information on
    dmesg and instead use %pK. %pK will only show the actual addresses if
    explicitly enabled under /proc/sys/kernel/kptr_restrict.

    Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/dwc3/dwc3-st.c | 2 +-
    drivers/usb/dwc3/gadget.c | 6 +++---
    2 files changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/usb/dwc3/dwc3-st.c
    +++ b/drivers/usb/dwc3/dwc3-st.c
    @@ -231,7 +231,7 @@ static int st_dwc3_probe(struct platform

    dwc3_data->syscfg_reg_off = res->start;

    - dev_vdbg(&pdev->dev, "glue-logic addr 0x%p, syscfg-reg offset 0x%x\n",
    + dev_vdbg(&pdev->dev, "glue-logic addr 0x%pK, syscfg-reg offset 0x%x\n",
    dwc3_data->glue_base, dwc3_data->syscfg_reg_off);

    dwc3_data->rstc_pwrdn =
    --- a/drivers/usb/dwc3/gadget.c
    +++ b/drivers/usb/dwc3/gadget.c
    @@ -1069,9 +1069,9 @@ static int __dwc3_gadget_ep_queue(struct
    return -ESHUTDOWN;
    }

    - if (WARN(req->dep != dep, "request %p belongs to '%s'\n",
    + if (WARN(req->dep != dep, "request %pK belongs to '%s'\n",
    &req->request, req->dep->name)) {
    - dwc3_trace(trace_dwc3_gadget, "request %p belongs to '%s'",
    + dwc3_trace(trace_dwc3_gadget, "request %pK belongs to '%s'",
    &req->request, req->dep->name);
    return -EINVAL;
    }
    @@ -1212,7 +1212,7 @@ static int dwc3_gadget_ep_dequeue(struct
    dwc3_stop_active_transfer(dwc, dep->number, true);
    goto out1;
    }
    - dev_err(dwc->dev, "request %p was not queued to %s\n",
    + dev_err(dwc->dev, "request %pK was not queued to %s\n",
    request, ep->name);
    ret = -EINVAL;
    goto out0;

    \
     
     \ /
      Last update: 2017-07-10 19:21    [W:4.058 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site