Messages in this thread | | | Date | Sat, 1 Jul 2017 17:17:07 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback |
| |
On Sat, Jul 01, 2017 at 11:57:32AM +0000, linyunsheng wrote: > Hi, Andrew > > I am agreed wih you on this. > But self test is also a feature of our product, and our > customer way choose to diagnose a problem using > self test, even if self test does not give a clear > reason to the problem. > we don't want to remove a feature that we don't > know when our customer will be using.
Far enough. So please take a close look at the code and try to fix it. The corner cases are your problem, a down'ed interface, WOL, etc. It is issues like this which can result in phy_resume() being called without there first being a phy_suspend.
Andrew
| |