Messages in this thread | | | From | Viresh Kumar <> | Date | Fri, 9 Jun 2017 18:02:30 +0530 | Subject | Re: [PATCH 0/3] cpufreq: schedutil: Fix 4.12 regressions |
| |
On 9 June 2017 at 17:54, Rafael J. Wysocki <rafael@kernel.org> wrote: > Hi, > > On Fri, Jun 9, 2017 at 12:15 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: >> Hi Rafael, >> >> I have identified some regressions with the schedutil governor which >> happen due to one of your patches that got merged in 4.12-rc1. >> >> This series fixes all the drivers which provide a ->target_index() >> callback but doesn't fix the drivers which provide ->target() callback. >> >> Such platforms need to implement the ->resolve_freq() callback in order >> to get this fixed and I only had hardware for testing intel_pstate, >> which I fixed in this series. >> >> I am wondering if there is another way to fix this issue (than what I >> tried) or if we should revert the offending commit (39b64aa1c007) and >> look for other solutions. > > To my eyes, patch [1/3] fixes the problem and then the remaining ones > deal with the issues resulting from that.
So I saw the issue reported and fixed by 2/3 first and noticed 1/3 while doing code reviews. So, 1/3 isn't the culprit really as the problem happens without it as well.
-- viresh
| |