lkml.org 
[lkml]   [2017]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio: mvebu: fix regmap_update_bits usage
Hello,

On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote:

> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 1);
> + BIT(pin), BIT(pin));
>
> return 0;
> }
> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
> mvebu_gpio_set(chip, pin, value);
>
> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 0);
> + BIT(pin), BIT(pin));

Are you sure here? We want to clear the bit, so I guess the 0 is
appropriate, no?

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2017-06-12 01:45    [W:0.048 / U:1.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site