Messages in this thread | | | From | Javier Martinez Canillas <> | Date | Wed, 7 Jun 2017 14:42:43 +0200 | Subject | Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM |
| |
Hello Masahiro,
On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
[snip]
>>> >>> Why didn't you touch >>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ? >>> >> >> Because the compatible string "microchip,24lc128" used by the I2C >> EEPROM node on that DTS is not supported by the >> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for >> 24lc128 I see is in that DTS). >> >> Maybe is a typo and it should be "microchip,24c128" instead ? > > I do not think so. > I consulted a board developer. > > I also see 24LC128 on Microchip web site: > http://www.microchip.com/wwwproducts/en/24LC128 >
Ah Ok, it was just a wild guess I did since the at24 driver didn't have support for this chip variant. My point stands though, this is an unrelated change to the goal of this patch-series and should be fixed separately.
Best regards, Javier
| |