lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver
Hayashibara-san

Just a nit.


> +
> +#include <linux/module.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/watchdog.h>
> +#include <linux/bitops.h>

I think you should have added <linux/bitops.h> on the top
to keep the includes alphabetically sorted.


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2017-06-12 01:20    [W:0.089 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site