Messages in this thread | | | From | Masahiro Yamada <> | Date | Thu, 8 Jun 2017 10:46:28 +0900 | Subject | Re: [PATCH] clk: sunxi-ng: Move all clock types to a library |
| |
2017-06-07 17:17 GMT+09:00 Maxime Ripard <maxime.ripard@free-electrons.com>: > On Wed, Jun 07, 2017 at 09:36:34AM +0200, Arnd Bergmann wrote: >> On Wed, Jun 7, 2017 at 7:45 AM, Chen-Yu Tsai <wens@csie.org> wrote: >> > at the bottom (with a comment) would be cleaner, and >> > we wouldn't need to modify all the existing lines. >> > AFAIK about Makefiles, that should work? >> >> Ah, yes. That's much better. >> >> Arnd > > I just applied the original patch, with that addition, and a comment > as suggested by Stephen. >
Hmm, I think Kbuild expects lib.a only for the final link (at least in official level) Is it a problem to compile common files all the time?
# Common objects obj-y += ccu_common.o obj-y += ccu_reset.o
We may end up with some unused functions in vmlinux, but it will not be a big impact on the image size in this case.
CONFIG_LD_DEAD_CODE_DATA_ELIMINATION may take care of unused symbols. I have not tested this CONFIG, though.
-- Best Regards Masahiro Yamada
| |