lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 037/250] powerpc: Convert cmp to cmpd in idle enter sequence
    Date
    From: Segher Boessenkool <segher@kernel.crashing.org>

    commit 80f23935cadb1c654e81951f5a8b7ceae0acc1b4 upstream.

    PowerPC's "cmp" instruction has four operands. Normally people write
    "cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
    people forget, and write "cmp" with just three operands.

    With older binutils this is silently accepted as if this was "cmpw",
    while often "cmpd" is wanted. With newer binutils GAS will complain
    about this for 64-bit code. For 32-bit code it still silently assumes
    "cmpw" is what is meant.

    In this instance the code comes directly from ISA v2.07, including the
    cmp, but cmpd is correct. Backport to stable so that new toolchains can
    build old kernels.

    Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
    Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
    Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Joel Stanley <joel@jms.id.au>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    arch/powerpc/kernel/idle_power7.S | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
    index e11863f..ccef172 100644
    --- a/arch/powerpc/kernel/idle_power7.S
    +++ b/arch/powerpc/kernel/idle_power7.S
    @@ -94,7 +94,7 @@ _GLOBAL(power7_nap)
    std r0,0(r1)
    ptesync
    ld r0,0(r1)
    -1: cmp cr0,r0,r0
    +1: cmpd cr0,r0,r0
    bne 1b
    PPC_NAP
    b .
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:17    [W:4.035 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site