lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 181/250] Input: hanwang - validate number of endpoints before using them
    Date
    From: Johan Hovold <johan@kernel.org>

    commit ba340d7b83703768ce566f53f857543359aa1b98 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: bba5394ad3bd ("Input: add support for Hanwang tablets")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/input/tablet/hanwang.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/input/tablet/hanwang.c b/drivers/input/tablet/hanwang.c
    index 5cc0412..263c85e 100644
    --- a/drivers/input/tablet/hanwang.c
    +++ b/drivers/input/tablet/hanwang.c
    @@ -341,6 +341,9 @@ static int hanwang_probe(struct usb_interface *intf, const struct usb_device_id
    int error;
    int i;

    + if (intf->cur_altsetting->desc.bNumEndpoints < 1)
    + return -ENODEV;
    +
    hanwang = kzalloc(sizeof(struct hanwang), GFP_KERNEL);
    input_dev = input_allocate_device();
    if (!hanwang || !input_dev) {
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:15    [W:4.042 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site