lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 060/250] ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 4763601a56f155ddf94ef35fc2c41504a2de15f5 upstream.

    The function returns -EINVAL even if it builds the stream properly.
    The bogus error code sneaked in during the code refactoring, but it
    wasn't noticed until now since the returned error code itself is
    ignored in anyway. Kill it here, but there is no behavior change by
    this patch, obviously.

    Fixes: e5779998bf8b ('ALSA: usb-audio: refactor code')
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    sound/usb/card.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/sound/usb/card.c b/sound/usb/card.c
    index 64952e2..7344ac0 100644
    --- a/sound/usb/card.c
    +++ b/sound/usb/card.c
    @@ -205,7 +205,6 @@ static int snd_usb_create_stream(struct snd_usb_audio *chip, int ctrlif, int int
    if (! snd_usb_parse_audio_interface(chip, interface)) {
    usb_set_interface(dev, interface, 0); /* reset the current interface */
    usb_driver_claim_interface(&usb_audio_driver, iface, (void *)-1L);
    - return -EINVAL;
    }

    return 0;
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:14    [W:3.482 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site