lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 151/250] fuse: add missing FR_FORCE
    Date
    From: Miklos Szeredi <mszeredi@redhat.com>

    commit 2e38bea99a80eab408adee27f873a188d57b76cb upstream.

    fuse_file_put() was missing the "force" flag for the RELEASE request when
    sending synchronously (fuseblk).

    If this flag is not set, then a sync request may be interrupted before it
    is dequeued by the userspace filesystem. In this case the OPEN won't be
    balanced with a RELEASE.

    [js] force is a variable, not a bit

    Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
    Fixes: 5a18ec176c93 ("fuse: fix hang of single threaded fuseblk filesystem")
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    fs/fuse/file.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/fuse/file.c b/fs/fuse/file.c
    index 7ada0f0..1dce930 100644
    --- a/fs/fuse/file.c
    +++ b/fs/fuse/file.c
    @@ -128,6 +128,7 @@ static void fuse_file_put(struct fuse_file *ff, bool sync)
    struct fuse_req *req = ff->reserved_req;

    if (sync) {
    + req->force = 1;
    req->background = 0;
    fuse_request_send(ff->fc, req);
    path_put(&req->misc.release.path);
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:14    [W:4.126 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site