Messages in this thread | | | From | "Jason A. Donenfeld" <> | Date | Tue, 6 Jun 2017 17:23:04 +0200 | Subject | Re: [kernel-hardening] Re: [PATCH v3 04/13] crypto/rng: ensure that the RNG is ready before using |
| |
Hey again Eric,
One thing led to another and I wound up just rewriting all the crypto in big_keys.c. I'll include this for v4:
https://git.zx2c4.com/linux-dev/commit/?h=jd/rng-blocker&id=886ff283b9808aecb14aa8e397da8496a9635aed
Not only was the use of crypto/rng inappropriate, but the decision to go with aes-ecb is shocking. Seeing that this author had no other commits in the tree, and that all subsequent commits that mentioned his name were cleaning up his mess, I just went ahead and removed both the crypto/rng misusage and changed from aes-ecb to aes-gcm.
Anyway, I'll wait for some more reviews on v3, and then this can be reviewed for v4.
Regards, Jason
| |