Messages in this thread | | | Date | Tue, 6 Jun 2017 11:58:49 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 3/5] ACPI / bus: Switch to use new generic UUID API |
| |
On Mon, Jun 05, 2017 at 10:37:41PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 5, 2017 at 6:20 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, 2017-06-05 at 18:03 +0200, Christoph Hellwig wrote: > >> > + in_params[0].buffer.pointer = (u8 *)&guid; > >> > >> Any idea why the pointer is defined as a u8 * in union acpi_object > >> instead of a void? > > > > I guess this question to Rafael. > > That data type is defined in upstream ACPICA and the reason why it is > defined the way it is has something to do with history I suppose.
Ok, I'll send a patch to fix it - just about every user of the field currently requires a cast, which is not a good thing.
| |