Messages in this thread Patch in this message | | | Subject | Re: [PATCH] perf: fix perf test case 14 result reporting | From | Thomas-Mich Richter <> | Date | Tue, 6 Jun 2017 07:02:57 +0200 |
| |
On 06/02/2017 04:11 PM, Arnaldo Carvalho de Melo wrote:
[....]
>> >> If you have specific patches in Jiri's branch that you think are good to >> go, just point me to them and I'll cherry-pick them. >> >> I'm looking now at the one you pointed out above (070b9644981e). > > Just looked, but the cset comment should state what is the problem and > how it is solved, right now it has just a one line summary :-\ > > - Arnaldo >
Looks like a misunderstanding. When I clone Jiri's tree and checkout branch perf/attr_test:
url = git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
oc2666213455 12 $ git branch master * perf/attr_test perf/stat oc2666213455 13 $ git show 070b9644981e commit 070b9644981e2dd160a6aae2723d0ec2d8b4c0b5 Author: Jiri Olsa <jolsa@kernel.org> Date: Fri Mar 3 15:59:45 2017 +0100
perf tests attr: Do not store failed events
diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c index 0dd7749..0f2b619 100644 --- a/tools/perf/tests/attr.c +++ b/tools/perf/tests/attr.c @@ -138,7 +138,7 @@ void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu, { int errno_saved = errno; - if (store_event(attr, pid, cpu, fd, group_fd, flags)) + if ((fd != -1) && store_event(attr, pid, cpu, fd, group_fd, flags)) die("test attr FAILED"); errno = errno_saved; oc2666213455 14 $ I get this commit which is another fix for an issue I discovered last week while working on test case 14.
-- Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany -- Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
| |