Messages in this thread | | | Date | Mon, 5 Jun 2017 15:36:17 -0400 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH] virtio_net: lower limit on buffer size |
| |
On Sat, Jun 03, 2017 at 11:17:30PM +0300, Sergei Shtylyov wrote: > On 06/02/2017 11:25 PM, J. Bruce Fields wrote: > > >>>commit d85b758f72b0 "virtio_net: fix support for small rings" > >> > >> Commit d85b758f72b0 ("virtio_net: fix support for small rings") > >> > >>>was supposed to increase the buffer size for small rings > >>>but had an unintentional side effect of decreasing > >>>it for large rings. This seems to break some setups - > >>>it's not yet clear why, but increasing buffer size > >>>back to what it was before helps. > >>> > >>>Fixes: d85b758f72b0 "virtio_net: fix support for small rings" > >> > >>Fixes: d85b758f72b0 ("virtio_net: fix support for small rings") > > > >I may be bikeshedding, but, personally I never do the parens--they're > >redundant given the quotes, and space is often tight. > > Just see Documetation/process/submitting-patches.rst.
Yeah, I know, I claim it's a bad rule (but I'm too lazy to send a patch, so, weight my opinion accordingly).
--b.
| |