lkml.org 
[lkml]   [2017]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kmod: add dependencies for test module
On Fri, Jun 30, 2017 at 05:47:44PM +0200, Arnd Bergmann wrote:
> When we try to 'select' drivers whose dependencies are not met,
> we get a kconfig warning and undefined behavior as further 'select'
> statements in those drivers can not be honored:
>
> warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET)
> warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF))
> ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined!
> ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined!
> ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined!
>
> To work around that, this adds the dependencies required by the
> 'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing
> that we can always enable those, and fixing the 'randconfig' issues.
>
> Unfortunately, there is another problem that I have not found a
> good solution for: If any of the three drivers are built-in rather
> than loadable modules, then the module load test will later fail
> at runtime.
>
> Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>

Luis

\
 
 \ /
  Last update: 2017-07-01 00:55    [W:0.054 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site