Messages in this thread | | | Subject | Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() | From | Sergei Shtylyov <> | Date | Fri, 30 Jun 2017 22:42:01 +0300 |
| |
On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote:
>>> > Print error message and propagate the return value of >>> > platform_get_irq on failure. >>> >>> You should have probably mentioned that this function no longer returns 0 >>> on error. >> >> Yeah, the patches looks good to me but I'd really appreciate more >> context in the changelogs. Gustavo, can you please respin the >> patches? >> > > Absolutely. > > What do you think about the following changelog: > > platform_get_irq() returns an error code, but the sata_rcar driver > ignores it and always returns -EINVAL. This is not correct, and
This *was* correct, because it prevented returning 0 on error.
> prevents -EPROBE_DEFER from being propagated properly.
Yes, this is a real problem.
> Print error message and propagate the return value of platform_get_irq > on failure. Also, with this change function sata_rcar_probe() no longer > returns 0 on error.
It never did -- I was talking about platform_get_irq() which might return 0 on error until I fixed it:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
> Thank you!
MBR, Sergei
| |