Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH] fs: GFS2: constify attribute_group structures. | Date | Fri, 30 Jun 2017 10:58:30 +0530 |
| |
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 5259 1344 8 6611 19d3 fs/gfs2/sys.o
File size After adding 'const': text data bss dec hex filename 5371 1216 8 6595 19c3 fs/gfs2/sys.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- fs/gfs2/sys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index 7a51534..01dc027 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c @@ -637,12 +637,12 @@ static ssize_t tune_set(struct gfs2_sbd *sdp, unsigned int *field, NULL, }; -static struct attribute_group tune_group = { +static const struct attribute_group tune_group = { .name = "tune", .attrs = tune_attrs, }; -static struct attribute_group lock_module_group = { +static const struct attribute_group lock_module_group = { .name = "lock_module", .attrs = lock_module_attrs, }; -- 1.9.1
| |