Messages in this thread | | | Date | Sat, 3 Jun 2017 19:22:33 +0900 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface |
| |
On Tue, May 16, 2017 at 03:08:14PM -0500, Andrew F. Davis wrote: > Like other subsystems we should be able to define slave devices outside > of the w1 directory. To do this we move public facing interface > definitions to include/linux/w1.h and rename the internal definition > file to w1_internal.h. > > As w1_family.h and w1_int.h contained almost entirely public > driver interface definitions we simply removed these files and > moved the remaining definitions into w1_internal.h. > > With this we can now start to move slave devices out of w1/slaves and > into the subsystem based on the function they implement, again like > other drivers. > > Signed-off-by: Andrew F. Davis <afd@ti.com> > Reviewed-by: Sebastian Reichel <sre@kernel.org>
This breaks the build for me: CC [M] drivers/power/supply/ds2760_battery.o drivers/power/supply/ds2760_battery.c:31:10: fatal error: ../../w1/w1.h: No such file or directory #include "../../w1/w1.h" ^~~~~~~~~~~~~~~ compilation terminated.
So there was w1 drivers outside of the drivers/w1/ directory :)
Please fix and resend.
thanks,
greg k-h
| |