Messages in this thread | | | Subject | Re: [PATCH 2/5] sched: Always set vtime_snap_whence after accounting vtime | From | Rik van Riel <> | Date | Thu, 29 Jun 2017 19:01:57 -0400 |
| |
On Thu, 2017-06-29 at 19:15 +0200, Frederic Weisbecker wrote: > Even though it doesn't have functional consequences, setting > the task's new context state after we actually accounted the pending > vtime from the old context state makes more sense from a review > perspective. > > vtime_user_exit() is the only function that doesn't follow that rule > and that can bug the reviewer for a little while until he realizes > there > is no reason for this special case. > > Cc: Wanpeng Li <kernellwp@gmail.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Luiz Capitulino <lcapitulino@redhat.com> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Rik van Riel <riel@redhat.com>
| |