Messages in this thread | | | Date | Thu, 29 Jun 2017 19:29:21 +0200 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH 2/4] swait: add the missing killable swaits |
| |
On Thu, Jun 29, 2017 at 04:31:08PM +0000, Matthew Wilcox wrote: > Linus Torvalds wrote: > > The thing is simply a collection of small hacks and should NOT be used > > in general. > > > > I never want to see a driver use that code, for example. It was > > designed for RCU and RT, and it should damn well be limited to that. > > Maybe put #ifndef MODULE around the entire include file then? > And definitely remove this line: > > * One would recommend using this wait queue where possible.
I'll respin and port away from swait, and add the #ifndef MODULE and special note on swait.h.
Luis
| |