Messages in this thread | | | Subject | Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() | From | Sagi Grimberg <> | Date | Thu, 29 Jun 2017 11:28:40 +0300 |
| |
>> Can you test just the one liner fix below? >> >>>> @@ -1452,7 +1452,7 @@ >>>> isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc) >>>> { >>>> struct isert_conn *isert_conn = wc->qp->qp_context; >>>> - struct ib_device *ib_dev = isert_conn->cm_id->device; >>>> + struct ib_device *ib_dev = isert_conn->device->ib_device; >>>> if (unlikely(wc->status != IB_WC_SUCCESS)) { >>>> isert_print_wc(wc, "login recv"); > > I'll test also this one-liner fix as soon as I can. > > But I can say that I'm pretty sure it will work as well, because all the > previous NULL pointer dereferences that we've got in the past happened > all 100% in isert_login_recv_done(). The other cases are probably a safe > precaution, but they can't really happen.
Agree, I'd prefer to start with a surgical fix before moving forward.
| |