lkml.org 
[lkml]   [2017]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] crypto: ccp - Introduce the AMD Secure Processor device
From
Date
On 6/28/2017 3:26 PM, Brijesh Singh wrote:
>
>
> On 06/28/2017 02:53 PM, Tom Lendacky wrote:
>>>
>>> In this I am leaving the top level config as-is and adding
>>> CONFIG_CRYPTO_DEV_SP_CCP to enable the CCP device support inside the
>>> SP device driver.
>>>
>>> [*] Support for AMD Secure Processor
>>> <M> Secure Processor device driver
>>> <M> Encryption and hashing offload support
>>> -*- Cryptographic Coprocessor device
>>
>> I think the "Encryption and hashing offload support" should be indented
>> under "Cryptographic Coprocessor device" since it is a function of the
>> CCP and not the SP. Not sure if we can remove a level of menu somehow,
>> something to explore.
>
> Good point, the updated Kconfig looks like this and let me know it works.

I think that looks better.

Thanks,
Tom

>
> [*] Support for AMD Secure Processor
> <M> Secure Processor device driver
> [*] Cryptographic Coprocessor device
> <M> Encryption and hashing offload support
>
> # cat drivers/crypto/ccp/Kconfig
>
> config CRYPTO_DEV_CCP_DD
> tristate "Secure Processor device driver"
> default m
> help
> Provides AMD Secure Processor device driver.
> If you choose 'M' here, this module will be called ccp.
>
> config CRYPTO_DEV_SP_CCP
> bool "Cryptographic Coprocessor device"
> default y
> depends on CRYPTO_DEV_CCP_DD
> select HW_RANDOM
> select DMA_ENGINE
> select DMADEVICES
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> help
> Provides the support for AMD Cryptographic Coprocessor (CCP)
> device
> which can be used to offload encryption operations such as
> SHA, AES
> and more.
>
> config CRYPTO_DEV_CCP_CRYPTO
> tristate "Encryption and hashing offload support"
> default m
> depends on CRYPTO_DEV_CCP_DD
> depends on CRYPTO_DEV_SP_CCP
> select CRYPTO_HASH
> select CRYPTO_BLKCIPHER
> select CRYPTO_AUTHENC
> help
> Support for using the cryptographic API with the AMD
> Cryptographic
> Coprocessor. This module supports offload of SHA and AES
> algorithms.
> If you choose 'M' here, this module will be called ccp_crypto.

\
 
 \ /
  Last update: 2017-06-28 22:30    [W:1.059 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site