lkml.org 
[lkml]   [2017]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] locking/atomics: don't alias ____ptr
On Wed, 28 Jun 2017, Mark Rutland wrote:
> On Wed, Jun 28, 2017 at 05:24:24PM +0200, Thomas Gleixner wrote:
> Given we're gonig to clean things up, we may as well avoid the backwards
> include of <asm-generic/atomic_instrumented.h>, whcih was only there as
> a bodge:
>
> For the UP arches we do:
> # echo '#include <asm-generic/atomic_up.h>' >arch/xxx/include/asm/atomic.h
> # mv include/asm-generic/atomic.h include/asm-generic/atomic_up.h
>
> Then we add a <linux/atomic_instrumented.h>:
>
> #ifndef __LINUX_ATOMIC_INSTRUMENTED_H
> #define __LINUX_ATOMIC INSTRUMENTED_H
>
> #include <asm/atomic.h>
>
> #if CONFIG_ATOMIC_INSTRUMENTED_H
> <instrumentation>
> #endif
>
> #endif /* __LINUX_ATOMIC_ARCH_H */
>
> ... and make <linux/atomic.h> incldue that rather than <asm/atomic.h>.
>
> That way the instrumentation's orthogonal to the UP-ness of the arch,
> and we can fold any other instrumentation in there, or later move it
> directly into <linux/atomic.h>

Sounds like a plan.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-06-28 20:22    [W:1.329 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site