lkml.org 
[lkml]   [2017]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] locking/atomics: don't alias ____ptr
On Wed, 28 Jun 2017, Dmitry Vyukov wrote:
> On Wed, Jun 28, 2017 at 2:24 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Wed, 28 Jun 2017, Dmitry Vyukov wrote:
> >> On Wed, Jun 28, 2017 at 1:10 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >> > #define cmpxchg_local(ptr, old, new) \
> >> > ({ \
> >> > - __typeof__(ptr) ____ptr = (ptr); \
> >> > - kasan_check_write(____ptr, sizeof(*____ptr)); \
> >> > - arch_cmpxchg_local(____ptr, (old), (new)); \
> >> > + kasan_check_write((ptr), sizeof(*(ptr))); \
> >> > + arch_cmpxchg_local((ptr), (old), (new)); \
> >>
> >>
> >> /\/\/\/\/\/\/\/\/\/\/\/\
> >>
> >> These are macros.
> >> If ptr is foo(), then we will call foo() twice.
> >
> > If that's true, the foo() will be evaluated a gazillion more times down the
> > way to the end of this macro maze.
>
> No. If we do:
>
> __typeof__(ptr) ____ptr = (ptr);
>
> and then only use ____ptr, then ptr is evaluated only once regardless
> of what the rest of macros do.

What I meant is, that we have today nested macros which do a lot of that
same nonsense even w/o that patch.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-06-28 15:34    [W:0.039 / U:2.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site