lkml.org 
[lkml]   [2017]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations
On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>> > - ret = -ENODEV;
>> > - goto e_adapt;
>> > + return -ENODEV;
>>
>> This is still shadows the actual error code.
>
> Nice catch. But since it fixes a seperate issue, I'd prefer an
> incremental change here.

Agreed.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-06-28 12:55    [W:0.105 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site