Messages in this thread | | | Date | Tue, 27 Jun 2017 17:16:58 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 1/2] iommu/s390: Use iommu_group_get_for_dev() in s390_iommu_add_device() |
| |
Hi Gerald,
sorry for the delay. Answers inline.
On Fri, Jun 16, 2017 at 07:33:01PM +0200, Gerald Schaefer wrote: > Seems pretty straightforward, so > Reviewed-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Thanks, I add it to the patch.
> With generic_device_group() returning NULL in case the allocation failed, > this part of iommu_group_get_for_dev() would then happily dereference the > NULL pointer, because IS_ERR(group) would be false:
Yeah, you are right, this is a bug. I'll send a patch to fix this shortly. I don't remember whether there was a good reason to drop the error values in the device_group call-backs. Probably there is none and I can just pass the error value up instead of NULLing them out.
Joerg
| |