Messages in this thread | | | Date | Mon, 26 Jun 2017 19:31:02 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH v1 2/6] [media] ov9650: add device tree support |
| |
Hi Hugues,
On Thu, Jun 22, 2017 at 05:05:38PM +0200, Hugues Fruchet wrote: > @@ -1545,15 +1577,22 @@ static int ov965x_remove(struct i2c_client *client) > } > > static const struct i2c_device_id ov965x_id[] = { > - { "OV9650", 0 }, > - { "OV9652", 0 }, > + { "OV9650", 0x9650 }, > + { "OV9652", 0x9652 },
This change does not appear to match with the patch description nor it the information is used. How about not changing it, unless there's a reason to? The same for the data field of the of_device_id array below.
> { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(i2c, ov965x_id); > > +static const struct of_device_id ov965x_of_match[] = { > + { .compatible = "ovti,ov9650", .data = (void *)0x9650 }, > + { .compatible = "ovti,ov9652", .data = (void *)0x9652 }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, ov965x_of_match); > static struct i2c_driver ov965x_i2c_driver = { > .driver = { > .name = DRIVER_NAME, > + .of_match_table = of_match_ptr(ov965x_of_match), > }, > .probe = ov965x_probe, > .remove = ov965x_remove,
-- Regards,
Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
| |