lkml.org 
[lkml]   [2017]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic
From
Date
On 06/26/2017 02:14 PM, Michal Hocko wrote:
> On Mon 26-06-17 13:45:19, Vlastimil Babka wrote:
>> On 06/23/2017 10:53 AM, Michal Hocko wrote:
> [...]
>>> - GFP_KERNEL - both background and direct reclaim are allowed and the
>>> _default_ page allocator behavior is used. That means that !costly
>>> allocation requests are basically nofail (unless the requesting task
>>> is killed by the OOM killer)
>>
>> Should we explicitly point out that failure must be handled? After lots
>> of talking about "too small to fail", people might get the wrong impression.
>
> OK. What about the following.
> "That means that !costly allocation requests are basically nofail but
> there is no guarantee of thaat behavior so failures have to be checked

that

> properly by callers (e.g. OOM killer victim is allowed to fail
> currently).

Looks good, thanks!

\
 
 \ /
  Last update: 2017-06-26 14:18    [W:0.072 / U:24.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site