> +> +static int internal_config_init(struct phy_device *phydev)> +{internal_ is a bit generic. The Marvell Ethernet switches haveinternal phy, etc. rockchip_ would be a better prefix. Andrew