lkml.org 
[lkml]   [2017]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX
    On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote:
    > Document the bindings for the Synopsys Designware HDMI RX.
    >
    > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
    > Cc: Carlos Palminha <palminha@synopsys.com>
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Cc: Mark Rutland <mark.rutland@arm.com>
    > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    > Cc: Hans Verkuil <hans.verkuil@cisco.com>
    > Cc: Sylwester Nawrocki <snawrocki@kernel.org>
    >
    > Changes from v3:
    > - Document the new DT bindings suggested by Sylwester
    > Changes from v2:
    > - Document edid-phandle property
    > ---
    > .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 70 ++++++++++++++++++++++
    > 1 file changed, 70 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt
    >
    > diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt
    > new file mode 100644
    > index 0000000..efb0ac3
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt
    > @@ -0,0 +1,70 @@
    > +Synopsys DesignWare HDMI RX Decoder
    > +===================================
    > +
    > +This document defines device tree properties for the Synopsys DesignWare HDMI
    > +RX Decoder (DWC HDMI RX). It doesn't constitute a device tree binding
    > +specification by itself but is meant to be referenced by platform-specific
    > +device tree bindings.
    > +
    > +When referenced from platform device tree bindings the properties defined in
    > +this document are defined as follows.
    > +
    > +- compatible: Shall be "snps,dw-hdmi-rx".
    > +
    > +- reg: Memory mapped base address and length of the DWC HDMI RX registers.
    > +
    > +- interrupts: Reference to the DWC HDMI RX interrupt and 5v sense interrupt.
    > +
    > +- clocks: Phandle to the config clock block.
    > +
    > +- clock-names: Shall be "cfg-clk".

    "-clk" is redundant.

    Seems strange that this is the only clock. The only other clock is the
    HDMI clock from the HDMI transmitter.

    > +
    > +- edid-phandle: phandle to the EDID handler block.
    > +
    > +- #address-cells: Shall be 1.
    > +
    > +- #size-cells: Shall be 0.
    > +
    > +You also have to create a subnode for phy driver. Phy properties are as follows.
    > +
    > +- compatible: Shall be "snps,dw-hdmi-phy-e405".
    > +
    > +- reg: Shall be JTAG address of phy.
    > +
    > +- clocks: Phandle for cfg clock.
    > +
    > +- clock-names:Shall be "cfg-clk".
    > +
    > +A sample binding is now provided. The compatible string is for a SoC which has
    > +has a Synopsys Designware HDMI RX decoder inside.
    > +
    > +Example:
    > +
    > +dw_hdmi_soc: dw-hdmi-soc@0 {
    > + compatible = "snps,dw-hdmi-soc";

    Not documented.

    > + reg = <0x11c00 0x1000>; /* EDIDs */
    > + #address-cells = <1>;
    > + #size-cells = <1>;
    > + ranges;
    > +
    > + dw_hdmi_rx@0 {

    hdmi-rx@0

    > + compatible = "snps,dw-hdmi-rx";
    > + reg = <0x0 0x10000>;
    > + interrupts = <1 2>;
    > + edid-phandle = <&dw_hdmi_soc>;

    Don't need this if it is the parent node.

    > +
    > + clocks = <&dw_hdmi_refclk>;
    > + clock-names = "cfg-clk";
    > +
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > +
    > + dw_hdmi_phy_e405@fc {

    hdmi-phy@fc

    > + compatible = "snps,dw-hdmi-phy-e405";
    > + reg = <0xfc>;
    > +
    > + clocks = <&dw_hdmi_refclk>;
    > + clock-names = "cfg-clk";
    > + };
    > + };
    > +};
    > --
    > 1.9.1
    >
    >

    \
     
     \ /
      Last update: 2017-06-23 23:59    [W:3.118 / U:1.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site