Messages in this thread | | | Date | Fri, 23 Jun 2017 10:54:56 -0700 | From | Benson Leung <> | Subject | Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP events support over ACPI |
| |
Hi Thierry,
On Fri, Jun 23, 2017 at 09:35:06AM +0200, Thierry Escande wrote: > Hi Benson, > > On 22/06/2017 21:35, Benson Leung wrote: > > <snip> > > >>+ adev = ACPI_COMPANION(dev); > >>+ if (adev) { > >>+ status = acpi_install_notify_handler(adev->handle, > >>+ ACPI_ALL_NOTIFY, > > > >Is there a reason you're using ACPI_ALL_NOTIFY here instead of > >ACPI_SYSTEM_NOTIFY that is done in the CHROMIUM version of this? > > > In the original patch > (https://chromium-review.googlesource.com/c/358155/) ACPI_ALL_NOTIFY > is passed to acpi_install_notify_handler() and ACPI_SYSTEM_NOTIFY to > acpi_remove_notify_handler. I changed it for remove_notify call to > unsure all handler references were removed. >
Oh, I see. Looks good. I'll go ahead and make the same change in the chromeos-4.4 kernel too.
Signed-off-by: Benson Leung <bleung@chromium.org>
Applied.
-- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org [unhandled content-type:application/pgp-signature] | |