lkml.org 
[lkml]   [2017]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] vsprintf: Add %p extension "%pOF" for device tree
On Thu, Jun 22, 2017 at 5:44 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 06/22/2017 01:44 PM, Rob Herring wrote:
>> From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>>
>> 90% of the usage of device node's full_name is printing it out in a
>> kernel message. However, storing the full path for every node is
>> wasteful and redundant. With a custom format specifier, we can generate
>> the full path at run-time and eventually remove the full path from every
>> node.
>>
>> For instance typical use is:
>> pr_info("Frobbing node %s\n", node->full_name);
>>
>> Which can be written now as:
>> pr_info("Frobbing node %pOF\n", node);
>
>
> isn't OF for flags -- and Of for full name?
> Typo or a change in the last 2 years?

It changed in the discussion 2 years ago. The intent is:

%pO - kobj
%pOF - device_node, defaulting to full name

There's no support of base kobj's, but I guess I should make that
intent clear in the documentation.

Rob

\
 
 \ /
  Last update: 2017-06-23 16:09    [W:0.072 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site